|  | Posted by Harlan Messinger on 11/16/06 20:52 
vitay wrote:> I have a page where button have the following java code:
 
 This isn't Java, it's Javascript.
 
 > onmouseover="style.cursor=\'hand\'; btn_img.src=\''.$img.'\';"
 
 You don't need to escape the single quotes that delimit the literal
 strings in the Javascript because you used double quotes to delimit the
 whole attribute. (Even if you do escape them, you have to use an HTML
 escape for them, not a Javascript one.) Removing the backslashes
 clarifies the existence of a problem:
 
 onmouseover="style.cursor='hand'; btn_img.src=''.$img.'';"
 
 The single quotes *inside* the string being assigned to btn_img.src *do*
 need to be escaped:
 
 onmouseover="style.cursor='hand'; btn_img.src='\'.$img.\'';"
 
 I don't see what sense this code makes anyway. If you want the cursor to
 turn into a pointer (not "hand"--that's IE-specific), you set the tag's
 style attribute (or use a separate stylesheet) from the outset instead
 of waiting for a mouseover:
 
 style="cursor: pointer;"
 
 As for the image's src property, even if $img expands into something
 else, I don't see how setting the src to
 
 '.http://www.example.com/resource.'
 
 is what you want.
  Navigation: [Reply to this message] |