|
|
Posted by Nik Coughlin on 04/03/07 22:52
Andy Dingley wrote:
> On 3 Apr, 01:25, "Nik Coughlin" <nrkn....@gmail.com> wrote:
>> Just implemented the html and css for a redesign of a game engine's
>> site. I was given a photoshop image for the design, so while I'll
>> pass along any comments on the look and feel that I get, I didn't do
>> that, and I'm more interested in critiques on the html + css.
>
> Too many ids, not enough classes on the major <div> Using class
> instead gives you an easier life with CSS selectors afterwards.
Yes, you're right, in fact I could probably not only make them class
instead, but get rid of a lot of them entirely.
> Reduce this stuff
> <!--[if lte IE 6]>
> If you must (and there are vanishingly small reasons to), then keep it
> down to the absolute bare minimum. At least you're using [if lte 6]
> though (a contained and diminishing problem), rather than [gte].
Yes, mainly to apply corrections to IE bugs (am using the Holly hack because
IE isn't drawing backgrounds on floated elements) and also to replace some
png files with gif because I didn't want to use the AlphaImageLoader hack,
I've seen pages that use it crash IE too many times, and randomly and
arbitrarily at that.
> I can't believe you need a "spacer.gif", especially sized in pixels,
> and unbelievably for IE6 specifically. For one thing this is a very
> simple layout - everything is full width, and it's width management
> that gives most IE-related problems.
Again, you're right. I was being lazy here.
>> Obviously this is just a
>> template with no content in it, the
>
> It won't tell you much until there's some visible content. Much of the
> need for prototyping depends on seeing how it responds to resizing,
> not just showing that you can get the boxes the right colour.
Can you stop being right already? :P I've done some testing and I've used
this technique before, IIRC it only breaks when you have floated content and
you don't clear it.
Thanks for your helpful comments Andy.
Navigation:
[Reply to this message]
|