|
Posted by Andy Dingley on 04/03/07 10:18
On 3 Apr, 01:25, "Nik Coughlin" <nrkn....@gmail.com> wrote:
> Just implemented the html and css for a redesign of a game engine's site. I
> was given a photoshop image for the design, so while I'll pass along any
> comments on the look and feel that I get, I didn't do that, and I'm more
> interested in critiques on the html + css.
Too many ids, not enough classes on the major <div> Using class
instead gives you an easier life with CSS selectors afterwards.
Reduce this stuff
<!--[if lte IE 6]>
If you must (and there are vanishingly small reasons to), then keep it
down to the absolute bare minimum. At least you're using [if lte 6]
though (a contained and diminishing problem), rather than [gte].
I can't believe you need a "spacer.gif", especially sized in pixels,
and unbelievably for IE6 specifically. For one thing this is a very
simple layout - everything is full width, and it's width management
that gives most IE-related problems.
> Obviously this is just a
> template with no content in it, the
It won't tell you much until there's some visible content. Much of the
need for prototyping depends on seeing how it responds to resizing,
not just showing that you can get the boxes the right colour.
[Back to original message]
|