Posted by -Lost on 06/07/07 06:28

pwiegers@gmail.com wrote:
> On 6 jun, 08:08, -Lost <maventheextrawo...@techie.com> wrote:
>> pwieg...@gmail.com wrote:
>>> Yes, I know, this is sort of commercial.. but how else to get people
>>> to, what I think, is a handy online applicaton?
>>> I created this app because I hate do document :) (Don't we all?)
>>> Sometimes I wanted to make a small diagram to depict what a piece of
>>> PHP-code does, a database relationship diagram, or, wel... But to do
>>> that in ASCII is hard, and not very much fun to do! So, I created this
>>> online app that allows you to draw simple diagrams in ASCII-chars
>>> only, so that you can save them in your comments in code. (You can
>>> also save them in Google Docs, or, well, where ever you want!).
>>> I showed it to some friends of mine; they like it. I needed a way to
>>> get it known to more people.. so, there we go:
>
>> I definitely think you need to button up your JavaScript.
>>
>> It didn't work for me in Firefox 1.5.0.11, Internet Explorer 6, or Opera
>> 9.10.
>
> I knew about Opera, but it works for my in IE 6 (6.2800.1106), and FF
> 1.5 :-(((
> (Note: on a slow computer, it might take 5 seconds or so to build the
> screen...)

Then that should tell you something right there.

> Can you tell me what happens? Do you get an JS-error?

Sure I can.

I see aa[x], and aa[fa] has no properties.

Or aa[] is null or not an object.

If I remember correctly [x] is dealing with your ROW and COLUMN
inserting/removing. The [fa] problem occurred when I hit the line
button and the delete everything button.

If I click one of the delete methods before doing *anything* it gives me
a single line running through the vertical center with *78*
(seventy-eight!) "undefined"s.

I noticed today, after having the page loaded in my browser forever. I
actually forgot about it whilst I tried to read your attempt at
obfuscated code. Or was that merely an attempt to minify?

Speaking of minifying, it strikes me really funny that your code is
exactly 500 lines. Well, assuming your beginning braces for functions
and conditionals start on the same line as them.

> thanks for the feedback!

Anytime. I would like to offer a few more items for digestion though.

Why not use DOM methods to create and insert the elements you need
instead of relying on the non-standard innerHTML to create *EVERYTHING*?

You realize that you exclude a *WIDE* range of browsers because of the
methods you employ?

Oh, and the only thing that I have *ever* seen work, is the new feature
you added to pinpoint where you click.

I think that's it for now...

--
-Lost
Remove the extra words to reply by e-mail. Don't e-mail me. I am
kidding. No I am not.

[Back to original message]