|
|
Posted by .:[ ikciu ]:. on 10/17/06 23:38
Hmm Steve <no.one@example.com> wrote:
conclusion
i just wanted to show you, your code is not perfect, in my country and it
this age you should to handle all, everytime some1 whants to crash you site
/ script / ..... you didn't make save code, i don't need to upload it on my
server, it is simple, if some1 will prepare url your script will crah, but
you cant to say YOU RIGHT :(
you are not begginer, but this thime you made mistake and this code should
be rewriten, what if you will insert data in few tables and one insert will
crash? you will lost part of data, and your system will be unstable because
when you will try to get data you will have only part, rest is dependent how
you will handle output functions
i think, there is no sense to speak more about it, think again about my
solution for this threed it is works, same as you i know my value and i
never speak about something what i never used,
P.S.
>>>> var el = record.personUserName;
>>>> if (warning.length == 0 && trim(el.value) == '')
>>>> {
>>>> warning = "USER NAME is required.";
>>>> }
>>>> var el = record.personEmail;
>>>> if (warning.length != 0 && !isEmail(el.value))
>>>> {
>>>> warning = "Invalid EMAIL.";
>>>> }
it only continues to check other fields if the previous fields are valid.
you're daft and can't read code.
you right, but for faster performance it should be nested,
i didn't sleep 53 hours, i just finished new site so i am tired but rest of
my comments are correct :) btw, why do you check length and later you check
empty string? why not same solution for both variables?
you said you will put it into class, don't do it before you will change the
code, im started on pascal, delphi, then c, c++, java then i migrate to php
but life teach us there is 2 base rules: 1 what user can do and what user
can't do, 2 validate and don't allow user to set value which is wrong for
adequate variable - error handling, it means we can write to parts of script
and the second is most imortant
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Ikciu | gg: 718845 | yahoo: ikciu_irsa | www: www.e-irsa.pl
2be || !2be $this => mysql_query();
Navigation:
[Reply to this message]
|