|
|
Posted by Jerry Stuckle on 12/11/06 08:09
Skijor wrote:
> I have inherited a php script that nests php, javascript, and html.
> How do I clean up code like this:
> I think I can move the javascript into a seperate .js file at the
> least. What about the nesting of php inside the html?
>
> <?php
>
> ...snip...
>
> function ShowCart()
> {
> ...
> ?>
> <html>
> ...
> <script language="JavaScript">
> function UpdateQty(item, backPage)
> {
> ...
> }
> </script>
> </head>
> <body bgcolor="#ffffff">
> ...
> <?php
> while($row = @mysql_fetch_array($result))
> {
> ...
> ?>
> <tr>
> <td width="15%" height="25">
> <font face="verdana" size="1" color="black">
> <select name="<?php echo $row["itemId"]; ?>"
> onChange="UpdateQty(this,'<?php echo $_GET['back']; ?>')">
> ....
> }
>
I guess I don't see switching back and forth between html and php as so
much of a problem. Most WYSIWYG editors won't display html code from an
echo or print statement, while they will plain html.
Although I do think this is a little strange - I normally don't have a
single function which does the headers, etc. Rather, most of my page is
HTML, with a PHP inserted as required. The code you inherited seems to
be mostly PHP with a little html thrown in.
--
==================
Remove the "x" from my email address
Jerry Stuckle
JDS Computer Training Corp.
jstucklex@attglobal.net
==================
Navigation:
[Reply to this message]
|