|
|
Posted by Rik on 02/07/07 03:55
Michael Fesser <netizen@gmx.de> wrote:
> .oO(Rik)
>
>> ft310 <ft310@yahoo.com> wrote:
>>
>>> $dcb =3D mysql_connect(/* some actually working creds */) ;
>>
>> I'd change the database password right now!
>
> Done.
>
> SCNR ;)
> Mi'of course not'cha
Hmmmz, that would be a laugh, changes his password ourselves... No, I'm =
=
not going to try it :P
Now, why the hell would one define a table with days of the week? Ah wel=
l, =
if nothing better to do, some free optimisation advise:
- Drop DaysGB, just use DATE_FORMAT(`DayNumber`,'%w') in MeetingsNewGB
- I'd create an index on MeetingCode in MeetingsNewGB.
- You really don't need an int(11) for DayNumber, int(1) should suffice.=
- You don't need MeetingDuration and MeetingTimes, these can easily by =
created from the other columns using TIMEDIFF(`MeetingStart`,`MeetingEnd=
`) =
and CONCAT(TIME_FORMAT(`MeetingStart`,'%h:%i %p'),' - =
',TIME_FORMAT(TIME_FORMAT(`MeetingEnd`,'%h:%i %p')));
- I see some CHAR(1) columns that seem to be used as a boolean field. =
int(1) is better for that.
- In a small database it's OK, but you might want to give `MeetingName` =
=
it's own table and just link to the id in MeetingsNewGB to avoid =
repetition.
The question now is: should I backup his database before it might get =
corrupted, or will I by doing that be guilty of theft? Ah, choices, =
choices....
-- =
Rik Wasmus
Navigation:
[Reply to this message]
|