|
|
Posted by biff on 04/12/07 21:24
John Hosking wrote:
>> http://mysite.verizon.net/vze1mdmy/test/
>>
>> It validates,
>
> Great! Good work, thanks for checking. And congrats.
When the site was done completely in tables it validated too. The
difference was of course it was 4.01 transitional instead of 4.01
strict. I realize validation is a good thing but it doesn't tell you
everything.
>
>> it renders the way I want in FF, IE6, Opera in Windows, and FF,
>> Opera, SeaMonkey and Lynx in Linux.
>
> Oh. Umm...
>
This is what I need to know. It does what I think it's supposed to do in
each of those browsers but what do you see ?
>>
>> I've munged it up some because of the sensitive nature of the site but
>> you should get the general gist of the way it's supposed to be.
>
> I'm not sure how to help you. Your munging hasn't kept the identity of
> the agency or the location or phone numbers of the offices secret, but
> it does make it hard to know what the site will really look like.
>
> What's the square in the upper right? Have you munged away an image of
> the "City" County seal? Or will it always be an empty, gray square? Is
> there supposed to be more in the picture at the left? Does the empty
> gray square explain photo of a highway? What have you hidden in the HTML
> at <div id="image"></div>?
Maybe I did a poor job of munging but I didn't want addresses and phone
numbers out in plain sight.
> The page "renders the way you want," so should we not comment on its
> sensitivity to text resizing?
I apologize for the way I worded that. Those are the comments that would
be most appreciated.
>Is the image of the cartoon family supposed to be stretched?
LOL...actually it is. Even my wife has commented on it but the site is
for her boss and she likes it soooooooo...
>Are we just supposed to comment on its look-and-feel, its coloring, its friendliness?
You can if you wish but I am mainly concerned with comments on the
markup and css. Keep in mind the "boss" is happy with the overall look
of the site.
> You've also posted a bit of disclaimer (which I've snipped), suggesting
> that if the coding's bad it's no big surprise or concern, because it
> used to be lots worse. What kind of feedback are you looking for?
>
That's not what I intended. It was more or less me laughing at
myself...If you think it's bad now you should have seen it before kind
of thing :)
What you have suggested below is the kind of feedback I'm looking for.
> FWIW: The link rules in the CSS should be in the order :link, :visited,
> :hover, :active (nmemonic: "Las Vegas Has Animals") rather than the
> order you've used.
I did not know that. Will be fixed.
> I think this is odd markup:
> <div class="innerright2"><strong>RESPONSE</strong> is a program of
> <strong>CCFHS</strong></div>
> <div class="innerright3"><strong>Offices are at:</strong>
> <ul id="menu">
> <li>54 Xxxxxx Street</li>
> <li>Xxxxxx 555-5555</li>
> <li><br>112 XxxxStreet</li>
> <li>Xxxxxxxxx 555-5555</li>
> <li><br>149 Xxxx Street</li>
> <li>Xxxxxxxxx 555-5555</li>
> </ul>
> </div>
>
> There's not much list-y about the addresses and phone numbers, it
> doesn't look like a "menu" either, you've got some spurious <br>s in
> there, and the divs are really just paragraphs or headers. I don't know
> what should be strong about "Offices are at", but if you just want the
> whole element to be bold, either mark it up with <b> (a Jukka(tm)
> suggestion) or apply font-weight:bold to the div's rule.
Good points, I understand and will correct, thank you. More of this is
helpful.
> A class name like "innerright2" won't tell you or anyone else about the
> semantic meaning of the element; it just says where you think it ought
> to be positioned. But what if you want it positioned elsewhere some day?
> What if you copy the text to another page? How about .officesHead (or
> something else semantically meaningful), if you can't get rid of the
> classing altogether?
I was never quite sure what that meant, now I do. Will fix.
> Why are you setting fixed widths in IE, and why in pixels?
yeah, I know...IE has been giving me a hard time. I'm still working on
it, bit by bit I'll get it right.
> Not sure what else to offer or suggest, because I'm not sure what
> feedback you're hoping for. But good luck.
>
You did a good job on what I gave you to work with. I'll be more
specific next time.
Navigation:
[Reply to this message]
|