|  | Posted by Erland Sommarskog on 04/30/07 21:31 
satish (satishkumar.gourabathina@gmail.com) writes:> CAn i have one trigger for both Update and Delete
 > Delete Trigger
 > ---------------------
 > create Trigger [tr_delete_user_log]
 > on [dbo].[user_log] for delete
 > as
 > begin
 > insert into z_user_log select * from deleted
 > end
 
 As Hugo said, you can. Permit me to point that your example exhibits
 two cases of bad practice:
 
 o   INSERT without a values list. If someone adds a column to user_log,
 the INSERT statement will fail.
 o   SELECT *. While convenient for ad hoc queries, it's bad in production
 code. In this example - if someone adds or removes a column - or
 just changes the column order, the INSERT statement will fail. SELECT *
 also make it more difficult to find where different columns are
 actually used.
 
 
 --
 Erland Sommarskog, SQL Server MVP, esquel@sommarskog.se
 
 Books Online for SQL Server 2005 at
 http://www.microsoft.com/technet/prodtechnol/sql/2005/downloads/books.mspx
 Books Online for SQL Server 2000 at
 http://www.microsoft.com/sql/prodinfo/previousversions/books.mspx
  Navigation: [Reply to this message] |