|
|
Posted by Gιrard Talbot on 01/20/06 07:33
Joe Barta wrote :
> Hello alt.html!
>
> Long time no see ;-)
>
> I made a little widget, CSS Button Designer.
I wonder why you did not present your CSS widget in a CSS newsgroup.
Wasn't this the logical thing to do for a "CSS Button Designer" web
application?
It's a tool for applying
> styles and optional javascript mouseover actions to simple buttons.
> It's pretty comprehensive and user-friendly.
Half of the whole page is covered with ads. And I'm not even mentioning
the unrequested popup served by media.fastclick.net/w/safepop.cgi here
and "FASTCLICK.COM POP-UNDER CODE v1.8".
> I'm very much open to feedback from this group. It's good, it sucks,
> this is right, this is wrong, this should be that, etc.
1- HTTP Charset
You have character encoding problems in your file; your server sends it
as utf-8 but, on line 10, you did not use characters which were encoded
as utf-8. It looks like you were not aware of the fact that your server
was sending your webpages encoded as utf-8.
2- Doctype declaration
Your document uses no doctype declaration. And your website
pagetutor.com gives HTML tutorials??
3- Markup code
If I choose HTML 4.01 strict and iso-8859-1 (Western) for the encoding
charset:
http://validator.w3.org/check?uri=http%3A%2F%2Fwww.pagetutor.com%2Fbutton_designer%2F&charset=iso-8859-1+%28Western+Europe%29&doctype=HTML+4.01+Strict&ss=1&verbose=1
193 errors.
I see that you're definitely not a model of avoiding deprecated elements
and attributes used for presentational purposes. align attribute is
specified 54 times; spacer.gif (aka empty.gif) 11 times; all kinds of
deprecated markup attributes (hspace, BACKGROUND, etc..
4- CSS code
This is how well you did with CSS code:
http://jigsaw.w3.org/css-validator/validator?uri=http%3A%2F%2Fwww.pagetutor.com%2Fbutton_designer%2F&usermedium=all
53 errors. 257 warnings. Don't you ever check your page with a validator
and then tell you yourself that you should fix these errors?
On top of that, your widget itself refuses all/any of the 17 reserved
keyword names for colors in CSS. So your widget does not comply with CSS
2.1.
If this widget was targeted toward browsers capable of rendering CSS,
then why did you resort to deprecated HTML attributes so often? Why not
*_use CSS_*? <shrug>
5- Javascript
I get all kinds of warnings about undeclared variables regarding your
page, a missing closing }, etc. etc.. Don't you ever look at a
javascript console to correct errors when you do a js-driven web
application?? to improve efficiency of your scripts? to increase your
browser audience? to reduce number of possible problems which may/could
occur, which you may not notice at first??
6- Accessibility
None, I repeat, none of your 22 text/radio/checkbox inputs use a single
HTML 4 label. No accesskey either. 0 label and accesskey. Your CSS code
uses repeatedly fixed, absolute font size. Your markup code uses on
nested tables. You use HREF="#". All of this is widely known to reduce
accessibility.
Your webpage is not scalable; instead it's more of a rigid, unflexible
page. You over-declare classes and over-define CSS rules, but that's
typical of over-constrained page layout and tables-based design used for
layout. You also use an awful lot of document.write() within the first
load of the page... which is suspicious.
> I'd be interested in any thoughts on that as well.
>
> Joe Barta
You write HTML tutorials and you were capable of writing such file?
Your page, widget, etc.. sucks. There. Fair and square.
GΓ©rard
--
remove blah to email me
Navigation:
[Reply to this message]
|